Sync is no longer working for me. I tried uninstalling the application, but apparently the data is saved so I can’t start over. Is sync currently working properly for MAC systems?
Yes it should be working just fine for mac. To remove any device from the Sync chain, open Brave on it and go to Settings --> Sync --> Managed Synced Devices --> Leave Sync chain. Do this for any devices currently on the chain, then simply create a new Sync chain to try again.
Same with me even after hitting Settings → Sync → Managed Synced Devices → Leave Sync chain. It seems the option on Mac does nothing.
I tried your solution. When I attempt to remove a device, I get a pop-up, answer yes, but the device is not removed. When I request a sync code, the code is only one word long. When I request to view the sync QR code, Brave crashes.
What should I do?
Can you please tell me what version of macOS you’re using at this time as well as the Brave version?
Can you please go to brave://crashes and submit any crash reports that occurred as a result of attempting to view the Sync code? If you’re unsure which ones they are, simply reproduce the crash, then go to brave://crashes and submit the most recent one.
Please reply back here with the crash report ID so our developers can review.
Is this the correct information?
cf1c0000-e66e-bc08-0000-000000000000
Upload Time:Wednesday, August 24, 2022 at 10:26:04 AM
@sbjohnson27 ,
brave:master ← brave:sync_warn_keyring_locked
opened 11:15AM - 19 Jul 22 UTC
Resolves https://github.com/brave/brave-browser/issues/24121
This PR does 4 t… hings:
1. Improvement of `TimeLimitedWords::GenerateForDate` / `TimeLimitedWords::Parse`. Now it returns base::expected result. This prevents the crash mentioned in issue and increases readability.
2. brave://sync-internals page is expanded with `Brave Sync` section and boolean fields `Passphrase is set`, `Passphrase decryption failed`, `OS encryption available` to make easier diagnostic of similar cases.
3. When Brave Sync has the passphrase set in preferences, but by any reason failed to decrypt it, brave://settings/braveSync/setup page displays `Browser could not decrypt the passphrase, Brave Sync is not running. Please check that browser has access to Keychain` message . The commit should be discussed, maybe it is not so necessary.
4. Adds the informer about Sync is not running for the case when decrypt seed failed.
**Screenshots:**
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [ ] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [ ] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [x] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [x] New files have MPL-2.0 license header
- [x] Adequate test coverage exists to prevent regressions
- [x] Major classes, functions and non-trivial code blocks are well-commented
- [x] Changes in component dependencies are properly reflected in `gn`
- [x] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [x] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
Test plan
1. Take clean profile
2. Launch browser
3. Open brave://sync-internals page. Expected to have
| Brave Sync | |
| --- | --- |
| Passphrase is set | false |
| OS encryption available | true |
5. Create a new sync chain. Open brave://sync-internals page. Expected to have
| Brave Sync | |
| --- | --- |
| Passphrase is set | true |
| OS encryption available | true |
6. Exit browser
7. Lock the keychain
8. Launch browser and don't grant the keychain access.
9. Expected to see informer `Sync service could not be started, Sync is not running`
10. Click `Check details` button - expected to open brave://settings/braveSync/setup page
11. Expected to see `Browser could not decrypt the passphrase, Brave Sync is not running. Please check that browser has access to secure OS passwords store. If you are using macOS, this is Keychain app. If you are using Ubuntu, this is Passwords and Keys app. Also don't use copied profile from other machines, this is not supported for security reasons.` .
12. Open brave://sync-internals page, expected to see
| Brave Sync | |
| --- | --- |
| Passphrase is set | true |
| Passphrase decryption failed | true |
| OS encryption available | false |
13. Exit browser, unlock the keychain, launch browser grant sync chain access.
14. Expected to see on brave://settings/braveSync/setup the regular settings, devices and data types.
Informer logic test:
1. Lock the keychain
2. Launch browser and don't grant the keychain access.
3. Expected to see informer `Sync service could not be started, Sync is not running`
4. Press `Don't show again`
5. Restart browser, don't grant keychain access
6. Expected not to see informer `Sync service could not be started, Sync is not running`
7. Restart browser, grant keychain access
8. Leave sync chain, create new sync chain
9. Restart browser, don't grant keychain access
10. Expected to see informer `Sync service could not be started, Sync is not running`
I granted Brave access, but it still crashes when I request the sync code.
@sbjohnson27 ,
@sbjohnson27 ,
You mentioned that you’re unable to leave the chain using the in-browser options. So instead, on each device, go to brave://sync-internals and use the Disable Sync (clear data) option:
