I’m using Brave 102.1.39.122
@StevenCee ,
289wk
June 10, 2022, 10:40pm
4
@StevenCee
Latest Brave Browser version is 1.39.122 (Thursday, June 9, 2022)
‘https://github.com/brave/brave-browser/releases/tag/v1.39.122 ’
IF the issue still exists, bring that to the attention of @Mattches
–
I do have this version, and the issue still persists, it’s not been fixed.
@StevenCee ,
289wk
June 14, 2022, 6:49am
8
@Mattches
Brave Browser for Mac OS v1.39.122
I am testing YouTube.
Mac keyboard sound volume control, does not cause the video to stop.
The sound volume control that is in the bottom-border area of the YouTube video . . . if adjusted, will make the video stop.
–
brave:master ← brave:brave-13586
opened 11:08AM - 05 Jul 22 UTC
Resolves https://github.com/brave/brave-browser/issues/13586
By default Chrom… ium paused videos on volume change if autoplay policy is set to block. In this case we skip this step.
## Submitter Checklist:
- [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one
- [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue
- [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above
- [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html)
- [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue
- [x] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint`
- [x] Ran `git rebase master` (if needed)
## Reviewer Checklist:
- [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in `gn`
- [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md)
- [ ] Test plan is specified in PR before merging
## After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the
changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
## Test Plan:
- block autoplay, open youtube videos and change volume
- video should not be stopped after that
–
This is my mistake — we have had/known about this issue for a while now:
opened 08:58PM - 14 Jan 21 UTC
priority/P3
feature/autoplay
feature/shields/webcompat
OS/Desktop
<!-- Have you searched for similar issues? Before submitting this issue, please … check the open issues and add a note before logging a new issue.
PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE.
INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->
## Description
When the `Autoplay` permission is set to `Block` (manually or by default), any interaction with a video player (ex Youtube), such as changing the volume of the video or sometimes jumping forward/backward to certain points in the video will cause the player to halt playback. The user then needs to start the video again manually. Note that this happens every time you go to adjust/interact with the player, not just the first time.
## Steps to Reproduce
1. In Brave v1.18.78 or higher, visit YouTube.com
2. Select a video to play and ensure that `Autoplay` is `Blocked` for YouTube, or that you select `Block` when prompted.
3. Start to stream the selected video.
4. In the player, attempt to change the playback volume and observe playback halted.
## Actual result:
Playback stops after interaction:
https://imgur.com/a/tAGdCLs
## Expected result:
Playback should only be halted on first load (since `Autoplay` = `Blocked`) or if the user pauses the video directly -- not when adjusting video settings.
## Reproduces how often:
Always
## Brave version (brave://version info)
Version 1.18.78 Chromium: 87.0.4280.141 (Official Build) (x86_64)
## Version/Channel Information:
- Can you reproduce this issue with the current release? Yes
- Can you reproduce this issue with the beta channel? Yes
- Can you reproduce this issue with the nightly channel? Yes
## Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? No
- Does the issue resolve itself when disabling Brave Rewards? No
- Is the issue reproducible on the latest version of Chrome? No
## Miscellaneous Information:
User thread:
https://community.brave.app/t/audio-stops-when-adjusting-volume-level/196109
cc @darkdh
I thought this had already been fixed a while back but apparently I was wrong. I’ve pinged some team members to take a look and get this fixed.
Can confirm, it happens with all website that features an autoplay content (Youtube, Vimeo, Linguee, Soundcloud…)
Just wanted to update and note that the fix for this has been implemented and pushed into Nightly. Should make its way down the pipeline soon. Appreciate everyone’s patience with this.