Vertical tabs and pinned tabs

anon57438784 · June 9, 2023, 6:32pm

Github is anyone’s bestfriend when it comes to Brave:

[May 21st] PR Implementing it and adding a flag for it.

github.com/brave/brave-core

Fix pinned tab container

brave:master ← brave:sko/vtab-fix-pin

opened 12:05PM - 21 May 23 UTC

sangwoo108

+440 -82

* Make Only unpinned tab container scrollable * Move views::ScrollView from Ver…ticalTabStripRegionView to BraveCompoundTabContainer to split scrollable area. https://github.com/brave/brave-core/assets/5474642/928c0f9c-f277-4949-846b-0b4d931d302d Resolves https://github.com/brave/brave-browser/issues/29935  ## Submitter Checklist: - [ ] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one - [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue - [ ] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above - [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html) - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR - [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue - [ ] Checked the PR locally: * `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests) * `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint` - [ ] Ran `git rebase master` (if needed) ## Reviewer Checklist: - [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description - [ ] New files have MPL-2.0 license header - [ ] Adequate test coverage exists to prevent regressions - [ ] Major classes, functions and non-trivial code blocks are well-commented - [ ] Changes in component dependencies are properly reflected in `gn` - [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md) - [ ] Test plan is specified in PR before merging ## After-merge Checklist: - [ ] The associated issue milestone is set to the smallest version that the changes has landed on - [ ] All relevant documentation has been updated, for instance: - [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) - [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs - [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections - [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes - [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers - [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave - [ ] https://github.com/brave/brave-browser/wiki/QA-Guide - [ ] https://github.com/brave/brave-browser/wiki/P3A ## Test Plan: * Enable brave://flags/#brave-vertical-tabs-stick-pinned-tabs and vertical tab strip * Add tabs until tabs are overflowed * Check if pinned tabs are not scrolled when scrolling tabs.

[Jun 7th] Making it Default behavior after Nightly 1.54.45.

github.com/brave/brave-core

Enable sticky pinned tabs by default

brave:master ← brave:sko/sticky

opened 02:33AM - 02 Jun 23 UTC

sangwoo108

+5 -1

* Also fixes resize handle problem that was missed during the rebase Resolv…es https://github.com/brave/brave-browser/issues/30761 Resolves https://github.com/brave/brave-browser/issues/30877  ## Submitter Checklist: - [ ] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one - [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue - [ ] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above - [ ] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html) - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR - [ ] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue - [ ] Checked the PR locally: * `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests` [wiki](https://github.com/brave/brave-browser/wiki/Tests) * `npm run lint`, `npm run presubmit` [wiki](https://github.com/brave/brave-browser/wiki/Presubmit-checks), `npm run gn_check`, `npm run tslint` - [ ] Ran `git rebase master` (if needed) ## Reviewer Checklist: - [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description - [ ] New files have MPL-2.0 license header - [ ] Adequate test coverage exists to prevent regressions - [ ] Major classes, functions and non-trivial code blocks are well-commented - [ ] Changes in component dependencies are properly reflected in `gn` - [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md) - [ ] Test plan is specified in PR before merging ## After-merge Checklist: - [ ] The associated issue milestone is set to the smallest version that the changes has landed on - [ ] All relevant documentation has been updated, for instance: - [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) - [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs - [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections - [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes - [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers - [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave - [ ] https://github.com/brave/brave-browser/wiki/QA-Guide - [ ] https://github.com/brave/brave-browser/wiki/P3A ## Test Plan:

Topic		Replies	Views
Fix location of pinned tabs in vertical tab layout Desktop Support feature-request	6	784	November 4, 2024
Pinned vertical tabs Desktop Requests feedback , feature-request	2	421	August 29, 2023
Pinned Vertical Tabs should be "Pinned" (always visible) Browser Feedback browser , design , feature-request	1	373	June 16, 2023
Vertical tabs no longer working after upgrade to version 1.47.171 Browser Support linux	13	2023	February 25, 2023
Vertical Tabs - Width and New Tab Button Desktop Requests	2	1336	June 6, 2023
Keep pins on vertical tabs sticky Brave Feature Requests	1	641	February 6, 2024
Implementation of Scrollable Tabs like in Firefox/Brave Mobile Desktop Requests browser	0	1524	July 4, 2019
Experimental Feature Tab Scrolling Desktop Support windows	7	7097	February 12, 2023

Vertical tabs and pinned tabs

[May 21st] PR Implementing it and adding a flag for it.

[Jun 7th] Making it Default behavior after Nightly 1.54.45.

Related topics