When community.brave.app/u/$USER/preferences/interface’s “Theme” is “Brave Default”, and its “Colour Palette” (especially its “Dark mode”'s) is Horizon:
…this breaks the interface:
You should permit upstream Discourse’s theme.
When community.brave.app/u/$USER/preferences/interface’s “Theme” is “Brave Default”, and its “Colour Palette” (especially its “Dark mode”'s) is Horizon:
…this breaks the interface:
You should permit upstream Discourse’s theme.
OP has found an issue with Discourse.
Mattches is a member of Brave Support and will probably not respond until after the weekend.
@RokeJulianLockhart yeah thanks for pointing this out. The “Horizon” theme/palette actually isn’t supposed to be selectable at this time. We will be reworking the sites’ theme in the near future to streamline the themes and ensure that we’re aligned with general branding.
I have removed those two themes from being selected for the time being.
@Mattches, I’m glad that you’ve remediated the immediate problem. However, for, at the least, the sake of accessibility, being able to select upstream’s theme and colour palettes is important; they put care into WCAG adherence.
To make sure I understand, does the supported dark theme not satisfy WCAG adherence?
I’m such a user who requires dark mode for accessibility, and I find this theme absolutely perfect, and is extremely easy on my eyes, especially by the fact it’s not high contrast as I have an astigmatism, making the text in my left eye far more readable without glasses actually.
To me, that passes WCAG adherence.
@MasterLink, I recommend that you observe //*[@data-name = ("WCAG Light", "WCAG Dark")] at meta.discourse.org/u/$USER/preferences/interface. For some people, higher contrast is of use, just as lower contrast is for some.
Which can potentially be solved by this Chromium flag since all Chromium related browsers have it, therefore taking the burden off of every single web dev (which is NOT fair, from someone disabled AND a sys admin).
(That’s with Brave set to Default, proving it does actually work.) Some sites it won’t work with, and those are the sites you’d want to target to fix. This site however does actually work here. Not to mention I simply use DarkReader as an extension to force websites into a dark mode that works best for me.
This “it’s gotta be fixed on every site” isn’t fair, sorry. It’s why we as disabled people have extensions, browser options, we can force things and accommodate. I don’t expect it to be per every site, heck no. Unrealistic.
Use the tools in front of you. ![]()
@RokeJulianLockhart yeah we have some custom theming options that have been implemented for a long time here – long before the “color palette” feature was available in Discord Discourse. It’s likely some conflict between the color values that have been hard-coded into the theme and the values used by the palette.
Most of the team (myself included) is either still on or just getting back from Holiday PTO and have lots of catching up to do, but I will make a note to prioritize this issue and allow users to select their desired color palettes as soon as I have the time. Appreciate your patience in the meantime.
@MasterLink, you haven’t read what I’ve written, and are evidently unfamiliar with Discourse. To reiterate, this instance has deviated from upstream, in a way that is disadvantageous, solely for aesthetic purposes.
It’s not a significant problem for me, but this useless discussion about the worth of my (slight) criticism is, because remediating this would merely be a matter of modifying a configuration file to display the original themes and palettes again: Theme.update_all(enabled: true).
If you believe that a mere flag, that applies a CSS override (!important), in solely Chromium-derived browsers, is a solution, I cannot spend time explaining the basics of web development to demonstrate why that is incorrect. Heck, I’m utilising firefox-146.0-3.fc43, where it’s entirely inapplicable!
What you’re looking for is html { colour-scheme: light dark }. Adhering to that is what Discourse does, with /preferences/interface#ember91’s “Auto” preference.
Brave’s developers do not require defence. They’re capable of speaking to me in a professional and competent manner alone, as has been demonstrated. This isn’t even a topic that requires defence. It’s barely a criticism.
@Mattches, thank you! (I presume you meant Discourse, BTW?
)
@RokeJulianLockhart yes I did – edited for clarity.
Going to go ahead and close this thread as it appears to have run its course. Please feel free to open a new thread if some time passes and I still haven’t gotten around to changing the theming to work with palettes.