I can't add favorite sites on my new tab

Chocoholic · June 29, 2022, 2:00pm

FYI: Fix currently in Brave Nightly 1.42.x

github.com/brave/brave-core

Fix layering issues with the NTP Add/Edit site dialog

brave:master ← brave:fix-edit-site-dialog

opened 09:22PM - 27 Jun 22 UTC

fallaciousreasoning

+1 -1

Resolves https://github.com/brave/brave-browser/issues/23685, https://github.com…/brave/brave-browser/issues/23689 This fixes two issues with the add/edit site dialog: 1. The dialog would show under the grid sites. 2. The dialog would close when clicking on a field (because the click would be handled by the layer above it). ## Submitter Checklist: - [x] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one - [x] There is a [ticket](https://github.com/brave/brave-browser/issues) for my issue - [x] Used Github [auto-closing keywords](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) in the PR description above - [x] Wrote a good [PR/commit description](https://google.github.io/eng-practices/review/developer/cl-descriptions.html) - [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR - [x] Added appropriate labels (`QA/Yes` or `QA/No`; `release-notes/include` or `release-notes/exclude`; `OS/...`) to the associated issue - [x] Checked the PR locally: `npm run test -- brave_browser_tests`, `npm run test -- brave_unit_tests`, `npm run lint`, `npm run gn_check`, `npm run tslint` - [x] Ran `git rebase master` (if needed) ## Reviewer Checklist: - [ ] A security review [is not needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or a link to one is included in the PR description - [ ] New files have MPL-2.0 license header - [ ] Adequate test coverage exists to prevent regressions - [ ] Major classes, functions and non-trivial code blocks are well-commented - [ ] Changes in component dependencies are properly reflected in `gn` - [ ] Code follows the [style guide](https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++.md) - [ ] Test plan is specified in PR before merging ## After-merge Checklist: - [ ] The associated issue milestone is set to the smallest version that the changes has landed on - [ ] All relevant documentation has been updated, for instance: - [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) - [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs - [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections - [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes - [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers - [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave - [ ] https://github.com/brave/brave-browser/wiki/QA-Guide - [ ] https://github.com/brave/brave-browser/wiki/P3A ## Test Plan:

Resolves brave/brave-browser#23685, brave/brave-browser#23689

This fixes two issues with the add/edit site dialog:

The dialog would show under the grid sites.

The dialog would close when clicking on a field (because the click would be handled by the layer above it).

Cannot add new favorite top site - #28 by Chocoholic
Screen recording of Top Sites dialogue working with mouse clicks on Brave Nightly

Topic		Replies	Views
Cannot add new favorite top site Desktop Support windows	26	5182	June 30, 2022
Cannot add a new website to add site in new tab browser	6	932	July 9, 2022
Unable to add a site url in browser's Top sites	5	1555	July 6, 2022
I cannot manually add websites to the the Top Sites section on my dashboard	11	1007	June 26, 2022
Adding top sites in brave Desktop Support windows	1	632	July 5, 2022
Top sites bug - someone knows how to fix it? Desktop Support windows	4	668	July 9, 2022
How to add favorite sites on brave?	5	31894	March 14, 2021
My brave "Add Site" button isn't working? Desktop Support windows	5	874	July 10, 2022

I can't add favorite sites on my new tab

Related topics